Skip to content

feat: expose pool_size and pool_idle_timeout as configurable options#36

Merged
joalves merged 4 commits intomainfrom
feat/configurable-connection-pool
Jan 26, 2026
Merged

feat: expose pool_size and pool_idle_timeout as configurable options#36
joalves merged 4 commits intomainfrom
feat/configurable-connection-pool

Conversation

@joalves
Copy link
Contributor

@joalves joalves commented Jan 26, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Add pool_size config option (default: 20) to control connection pool size
  • Add pool_idle_timeout config option (default: 5) to set idle connection timeout in seconds
  • Update README with new configuration options
  • Add tests for the new options

Test plan

  • All 252 existing tests pass
  • New tests verify custom and default values for pool settings
  • Documentation updated in README.md and CHANGELOG.md

Summary by CodeRabbit

  • New Features

    • Added configurable connection pool settings: pool_size and pool_idle_timeout. These settings enable fine-tuning of connection pooling to suit specific application requirements. Default values: pool_size of 20 and pool_idle_timeout of 5 seconds.

  • Documentation

    • Updated configuration guide with new pooling options and usage examples.

✏️ Tip: You can customize this high-level summary in your review settings.

@joalves
feat: expose pool_size and pool_idle_timeout as configurable options
a7a552f 
Add configurable connection pool settings for the HTTP client:
- pool_size (default: 20) - number of connections in the pool
- pool_idle_timeout (default: 5) - seconds before idle connections close

This allows customers to tune connection pooling behavior based on their
specific workload requirements.
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026 •
edited
Loading

Warning

Rate limit exceeded

@joalves has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

This pull request introduces configurable HTTP connection pool settings to the Ruby SDK. Two new configuration attributes—pool_size (default: 20) and pool_idle_timeout (default: 5)—are added to the DefaultHttpClientConfig class. The implementation replaces hardcoded values in the HTTP client initialisation with these config-driven values. The changes include documentation updates in the README and CHANGELOG, implementation modifications to wire the configuration into the Faraday adapter, and comprehensive test coverage for both the new attributes and their integration with the HTTP client.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • calthejuggler
  • cwmpinho

Poem

🐰 Pools of wisdom, now we configure!
Pool size and timeouts, set them higher—
No more hardcoded, stiff and rigid,
Flexibility blooms in this pivotal mid-field! ✨🔧

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: exposing pool_size and pool_idle_timeout as configurable options. It clearly summarises the primary objective of the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joalves joalves force-pushed the feat/configurable-connection-pool branch 2 times, most recently from ef31f69 to 69aecf2 Compare January 26, 2026 10:13
@joalves joalves force-pushed the feat/configurable-connection-pool branch from 69aecf2 to a183ced Compare January 26, 2026 10:13
calthejuggler
calthejuggler approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@calthejuggler calthejuggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@joalves joalves merged commit 2b09db3 into main Jan 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calthejuggler calthejuggler calthejuggler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joalves @calthejuggler